Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] WIP - PAC Comparator #3926

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Jul 21, 2020

Summary

This is a testing, work in progress PR for the PAC Comparator I was playing with during the 12.x innovation sprint.

Impacted areas of the application

The committees section / template

Screenshots

image

Related PRs

None?

How to test

  • pull the branch
  • npm i
  • npm run build
  • ./manage.py runserver
  • http://127.0.0.1:8000/data/browse-data/?tab=committees
  • check nonconnected committees, and the non-nonconnected ones to double-check that the error appears
  • check that data and warnings update when the time period is changed
  • check numbers
  • try to break it

Next steps

Being that this was a proof of concept and scrappy v0, there are still plenty of todos before this is ready for production. Here are some as they pop into my head:

  • put behind an env var
  • pull the code out of the hard-coded template
  • put the css into scss files
  • make it responsive
  • handle the 'loading' state
  • polish look & feel
  • decide on visualizations and usability/accessibility
  • tell Vue to build for prod, not dev
  • triple verify calculations
  • there's a ticket for a is_nonconnected var, which would alleviate a chunk of logic in here
  • there's another ticket for a nonconnected typeahead option
  • remove console logs
  • remove unused code (including unused Vue components)
  • better documentation
  • make Vue components more modular?
  • if it's out by then, update to Vue 3?
  • more, I'm sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build layout of the PAC spending chart
1 participant